Bug 8479 - WinSerialStream calls Marshal.StructureToPtr with incorrect parameter
Summary: WinSerialStream calls Marshal.StructureToPtr with incorrect parameter
Status: NEW
Alias: None
Product: Class Libraries
Classification: Mono
Component: System (show other bugs)
Version: unspecified
Hardware: PC Windows
: --- normal
Target Milestone: Untriaged
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2012-11-17 20:33 UTC by Alex
Modified: 2012-11-21 10:02 UTC (History)
1 user (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report for Bug 8479 on GitHub or Developer Community if you have new information to add and do not yet see a matching new report.

If the latest results still closely match this report, you can use the original description:

  • Export the original title and description: GitHub Markdown or Developer Community HTML
  • Copy the title and description into the new report. Adjust them to be up-to-date if needed.
  • Add your new information.

In special cases on GitHub you might also want the comments: GitHub Markdown with public comments

Related Links:
Status:
NEW

Description Alex 2012-11-17 20:33:26 UTC
Constructor of WinSerialStream class calls twice Marshal.StructureToPtr method on lines 114 and 120 of WinSerialStream.cs. The third parameter of StructureToPtr - fDeleteOld, is specified as "true" but it must be "false" because StructureToPtr operates with newly allocated memory and there is nothing to be deleted there. In this case StructureToPtr does not crash just because NativeOverlapped structure does not contain fields of reference type.
Comment 1 Alex 2012-11-21 10:02:18 UTC
To be more precise - the following lines in WinSerialStreamcs

Marshal.StructureToPtr (wo, write_overlapped, true);
...
Marshal.StructureToPtr (ro, read_overlapped, true);

should become

Marshal.StructureToPtr (wo, write_overlapped, false);
...
Marshal.StructureToPtr (ro, read_overlapped, false);