Bug 59902 - Update PingTest.PingSuccess() for Android
Summary: Update PingTest.PingSuccess() for Android
Status: NEW
Alias: None
Product: Runtime
Classification: Mono
Component: General (show other bugs)
Version: unspecified
Hardware: PC Mac OS
: --- normal
Target Milestone: ---
Assignee: Marek Habersack
URL:
Depends on:
Blocks:
 
Reported: 2017-10-02 16:17 UTC by Jonathan Pryor
Modified: 2017-10-02 16:24 UTC (History)
2 users (show)

See Also:
Tags:
Is this bug a regression?: ---
Last known good build:


Attachments

Description Jonathan Pryor 2017-10-02 16:17:13 UTC
Context: Bug #34883
Context: https://github.com/xamarin/xamarin-android/pull/872

The `MonoTests.System.Net.NetworkInformation.PingTest.PingSuccess()` test does not work on all Android devices, becomes some of them don't permit `ping`ing localhost. (Android, everyone!)

This was fixed with Bug #34883 by skipping execution of the test on certain "known bad" Android devices. However, this fix was never merged with mono proper.

Update the `MonoTests.System.Net.NetworkInformation.PingTest.PingSuccess()` test so that the device rejection logic is within mono, so that when xamarin-android uses the mono tests as-is, the correct behavior will continue to be used.
Comment 1 Jonathan Pryor 2017-10-02 16:24:08 UTC
A similar thing should be done for `Mono.Unix.Android.TestHelper.CanUseRealTimeSignals()`.

Note You need to log in before you can comment on or make changes to this bug.