Bug 59317 - [appkit/uikit] Simplify NSAttributedString (currently split in 3 frameworks)
Summary: [appkit/uikit] Simplify NSAttributedString (currently split in 3 frameworks)
Status: CONFIRMED
Alias: None
Product: iOS
Classification: Xamarin
Component: Xamarin.iOS.dll (show other bugs)
Version: XI 10.99 (xcode9)
Hardware: PC Mac OS
: Normal enhancement
Target Milestone: Future Cycle (TBD)
Assignee: Vincent Dondain [MSFT]
URL:
Depends on:
Blocks:
 
Reported: 2017-09-08 04:04 UTC by Vincent Dondain [MSFT]
Modified: 2017-11-29 17:07 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report for Bug 59317 on Developer Community or GitHub if you have new information to add and do not yet see a matching new report.

If the latest results still closely match this report, you can use the original description:

  • Export the original title and description: Developer Community HTML or GitHub Markdown
  • Copy the title and description into the new report. Adjust them to be up-to-date if needed.
  • Add your new information.

In special cases on GitHub you might also want the comments: GitHub Markdown with public comments

Related Links:
Status:
CONFIRMED

Description Vincent Dondain [MSFT] 2017-09-08 04:04:40 UTC
NSAttributedString constants are defined in multiple places:

[iOS/Mac] Foundation’s NSAttributedString (x3 cause there are 3 declarations) + DictionaryContainer in NSAttributedString.mac.cs (missing iOS strong dictionary)
[iOS] UIKit’s UIStringAttributeKey + DictionaryContainer in NSAttributedString.iOS.cs
[Mac] AppKit’s NSStringAttributeKey + DictionaryContainer in NSStringAttributes.cs && NSAttributedString.mac.cs (edited)

Some stuff in UIKit, some in appkit, some in foundation (but duplicated Fields cause they are also in AppKit), actually in all 3 frameworks.

We have `NSStringAttributes.cs` and `NSAttributedString.mac.cs` (there seems to be some duplication).

In PR 2599 I added the new field to https://github.com/VincentDondain/xamarin-macios/blob/0c4bf1a9c5f80e9cca56a07de9e9480ce1287802/src/foundation.cs#L13185-L13255 but I’m not sure this should actually live in `foundation.cs` maybe the separation between AppKit and UIKit is the way to go.

This feels like it's just adding to the mess so we may want to simplify things (:
Comment 1 Sebastien Pouliot 2017-11-29 17:07:04 UTC
https://github.com/xamarin/xamarin-macios/pull/2599