Bug 58698 - [generator] Add support for inlining constructors and static methods from protocols
Summary: [generator] Add support for inlining constructors and static methods from pro...
Status: CONFIRMED
Alias: None
Product: iOS
Classification: Xamarin
Component: Tools (show other bugs)
Version: master
Hardware: PC Mac OS
: --- enhancement
Target Milestone: Future Cycle (TBD)
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2017-08-10 13:58 UTC by Rolf Bjarne Kvinge [MSFT]
Modified: 2017-08-10 13:58 UTC (History)
1 user (show)

Tags:
Is this bug a regression?: No
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report for Bug 58698 on Developer Community or GitHub if you have new information to add and do not yet see a matching new report.

If the latest results still closely match this report, you can use the original description:

  • Export the original title and description: Developer Community HTML or GitHub Markdown
  • Copy the title and description into the new report. Adjust them to be up-to-date if needed.
  • Add your new information.

In special cases on GitHub you might also want the comments: GitHub Markdown with public comments

Related Links:
Status:
CONFIRMED

Description Rolf Bjarne Kvinge [MSFT] 2017-08-10 13:58:15 UTC
Right now neither of these methods will be inlined in the class C:

[Protocol]
interface P {
    [Export ("initSomething")]
    IntPtr Constructor ()

    [Export ("staticSomething")]
    [Static]
    IntPtr StaticSomething ();
}

[BaseType (typeof (NSObject))
interface C : P
{
}

I suggest we implement inlining for these members, like we already do for normal methods and properties.

One benefit is that we'd be able to remove the code that manually adds the NSCoder constructor, since it would be automatically pulled in by types that implements the NSCoding protocol.

It also makes it possible to remove code duplication, since currently constructors and static methods have to be inlined automatically.

There's a half-done implementation here: https://github.com/rolfbjarne/xamarin-macios/tree/ctors-in-protocols2 (priority dropped when Apple renamed the constructors in their protocols to not be constructors anymore; see bug #57650).