Bug 58698 - [generator] Add support for inlining constructors and static methods from protocols
Summary: [generator] Add support for inlining constructors and static methods from pro...
Status: CONFIRMED
Alias: None
Product: iOS
Classification: Xamarin
Component: Tools (show other bugs)
Version: master
Hardware: PC Mac OS
: --- enhancement
Target Milestone: Future Cycle (TBD)
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2017-08-10 13:58 UTC by Rolf Bjarne Kvinge [MSFT]
Modified: 2017-08-10 13:58 UTC (History)
1 user (show)

See Also:
Tags:
Is this bug a regression?: No
Last known good build:


Attachments

Description Rolf Bjarne Kvinge [MSFT] 2017-08-10 13:58:15 UTC
Right now neither of these methods will be inlined in the class C:

[Protocol]
interface P {
    [Export ("initSomething")]
    IntPtr Constructor ()

    [Export ("staticSomething")]
    [Static]
    IntPtr StaticSomething ();
}

[BaseType (typeof (NSObject))
interface C : P
{
}

I suggest we implement inlining for these members, like we already do for normal methods and properties.

One benefit is that we'd be able to remove the code that manually adds the NSCoder constructor, since it would be automatically pulled in by types that implements the NSCoding protocol.

It also makes it possible to remove code duplication, since currently constructors and static methods have to be inlined automatically.

There's a half-done implementation here: https://github.com/rolfbjarne/xamarin-macios/tree/ctors-in-protocols2 (priority dropped when Apple renamed the constructors in their protocols to not be constructors anymore; see bug #57650).

Note You need to log in before you can comment on or make changes to this bug.