Bug 58350 - [generator] Handle sharpie's [RequiresSuper]
Summary: [generator] Handle sharpie's [RequiresSuper]
Status: RESOLVED FIXED
Alias: None
Product: iOS
Classification: Xamarin
Component: Tools (show other bugs)
Version: master
Hardware: PC Mac OS
: Normal enhancement
Target Milestone: 15.7
Assignee: Sebastien Pouliot
URL:
Depends on:
Blocks:
 
Reported: 2017-07-25 03:28 UTC by Sebastien Pouliot
Modified: 2018-01-04 21:26 UTC (History)
2 users (show)

See Also:
Tags:
Is this bug a regression?: No
Last known good build:


Attachments

Description Sebastien Pouliot 2017-07-25 03:28:17 UTC
Accept the attribute in the generator and, minimally, output something like:

> [Advice ("You must call the base method when overriding.")]

in the generated code.

This will allow the IDE to show the requirement to the developer.
Comment 1 Sebastien Pouliot 2017-07-25 03:32:39 UTC
This can be done manually until then, 
e.g. https://github.com/xamarin/xamarin-macios/pull/2364

Ideally we need to update xtro to report missing cases.
Comment 2 Manuel de la Peña [MSFT] 2017-08-02 15:57:46 UTC
@Sebastien, setting this to confirmed to keep the backlog clean and not get confused.
Comment 4 Sebastien Pouliot 2018-01-02 18:15:23 UTC
https://github.com/xamarin/xamarin-macios/pull/3147
Comment 5 Sebastien Pouliot 2018-01-04 21:26:49 UTC
merge in master with https://github.com/xamarin/xamarin-macios/commit/ec744533b9e51f1cb1a748b8a2375195abd0a66a

Note You need to log in before you can comment on or make changes to this bug.