Bug 46938 - Toolbar Subtitle Reset When Screen Rotated
Summary: Toolbar Subtitle Reset When Screen Rotated
Alias: None
Product: Forms
Classification: Xamarin
Component: Android (show other bugs)
Version: 2.3.3
Hardware: PC Mac OS
: --- normal
Target Milestone: ---
Assignee: Bugzilla
Depends on:
Reported: 2016-11-14 17:27 UTC by Jimmy [MSFT]
Modified: 2016-11-25 09:19 UTC (History)
4 users (show)

See Also:
Is this bug a regression?: ---
Last known good build:

repro project (710.63 KB, application/zip)
2016-11-14 17:27 UTC, Jimmy [MSFT]

Description Jimmy [MSFT] 2016-11-14 17:27:58 UTC
Created attachment 18453 [details]
repro project

### Overview
The Toolbar subtitle text set via a custom NavigationPage renderer is removed when the screen orientation changes. This happens because the Toolbar is reset every time OnLayout() is called: https://github.com/xamarin/Xamarin.Forms/blob/master/Xamarin.Forms.Platform.Android/AppCompat/NavigationPageRenderer.cs#L282

### Steps to Reproduce 
1. Run the attached Android project
2. Rotate the device/emulator

### Expected Results
The subtitle text will remain.

### Actual Results
The Toolbar subtitle text will disappear.

### Workaround
You can detect when the Height or Width changes in OnElementPropertyChanged() which should indicate an orientation change and call SetSubtitle() again.

### Testing Info
Tested with Forms 2.3.2 and 2.3.3-pre3
Comment 1 adrianknight89 2016-11-14 23:31:55 UTC
See https://github.com/xamarin/Xamarin.Forms/pull/528
Comment 2 Samantha Houts [MSFT] 2016-11-16 20:49:01 UTC
Should be fixed in 2.3.4-pre1. Thank you!
Comment 3 Parmendra Kumar 2016-11-25 09:19:42 UTC
I have checked this issue with Xamarin.Forms 2.3.4-pre1 and observed that this issue has been fixed.

Hence closing this issue.


Note You need to log in before you can comment on or make changes to this bug.