Bug 46316 - [APIBreak] wrong return types in WebUIDelegate UIDragSourceActionMask and UIGetDragDestinationActionMask
Summary: [APIBreak] wrong return types in WebUIDelegate UIDragSourceActionMask and UIG...
Status: CONFIRMED
Alias: None
Product: Xamarin.Mac
Classification: Desktop
Component: Library (Xamarin.Mac.dll) (show other bugs)
Version: Master
Hardware: PC Mac OS
: Normal normal
Target Milestone: Future Cycle (TBD)
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2016-11-02 17:45 UTC by Vsevolod Kukol
Modified: 2016-11-02 19:38 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: No
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report for Bug 46316 on Developer Community or GitHub if you have new information to add and do not yet see a matching new report.

If the latest results still closely match this report, you can use the original description:

  • Export the original title and description: Developer Community HTML or GitHub Markdown
  • Copy the title and description into the new report. Adjust them to be up-to-date if needed.
  • Add your new information.

In special cases on GitHub you might also want the comments: GitHub Markdown with public comments

Related Links:
Status:
CONFIRMED

Description Vsevolod Kukol 2016-11-02 17:45:55 UTC
The return types of WebUIDelegate.UIDragSourceActionMask and WebUIDelegate.UIGetDragDestinationActionMask are both 
NSEventModifierMask, but it should be WebDragSourceAction and WebDragDestinationAction.

Thanks!
Comment 1 Chris Hamons 2016-11-02 19:38:04 UTC
Header

- (NSUInteger)webView:(WebView *)webView dragSourceActionMaskForPoint:(NSPoint)point;

- (NSUInteger)webView:(WebView *)webView dragDestinationActionMaskForDraggingInfo:(id <NSDraggingInfo>)draggingInfo;


Binding

		[Export ("webView:dragDestinationActionMaskForDraggingInfo:"), DelegateName ("DragDestinationGetActionMask"), DefaultValue (0)]
		NSEventModifierMask UIGetDragDestinationActionMask (WebView webView, NSDraggingInfo draggingInfo);

		[Export ("webView:dragSourceActionMaskForPoint:"), DelegateName ("DragSourceGetActionMask"), DefaultValue (0)]
		NSEventModifierMask UIDragSourceActionMask (WebView webView, CGPoint point);

Looks like you are correct. Unfortunately, we won't be able to fix it without breaking API compat, so it will have to wait until the next API break.