Bug 46316 - [APIBreak] wrong return types in WebUIDelegate UIDragSourceActionMask and UIGetDragDestinationActionMask
Summary: [APIBreak] wrong return types in WebUIDelegate UIDragSourceActionMask and UIG...
Status: CONFIRMED
Alias: None
Product: Xamarin.Mac
Classification: Desktop
Component: Library (Xamarin.Mac.dll) (show other bugs)
Version: Master
Hardware: PC Mac OS
: Normal normal
Target Milestone: Future Cycle (TBD)
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2016-11-02 17:45 UTC by Vsevolod Kukol
Modified: 2016-11-02 19:38 UTC (History)
2 users (show)

See Also:
Tags:
Is this bug a regression?: No
Last known good build:


Attachments

Description Vsevolod Kukol 2016-11-02 17:45:55 UTC
The return types of WebUIDelegate.UIDragSourceActionMask and WebUIDelegate.UIGetDragDestinationActionMask are both 
NSEventModifierMask, but it should be WebDragSourceAction and WebDragDestinationAction.

Thanks!
Comment 1 Chris Hamons 2016-11-02 19:38:04 UTC
Header

- (NSUInteger)webView:(WebView *)webView dragSourceActionMaskForPoint:(NSPoint)point;

- (NSUInteger)webView:(WebView *)webView dragDestinationActionMaskForDraggingInfo:(id <NSDraggingInfo>)draggingInfo;


Binding

		[Export ("webView:dragDestinationActionMaskForDraggingInfo:"), DelegateName ("DragDestinationGetActionMask"), DefaultValue (0)]
		NSEventModifierMask UIGetDragDestinationActionMask (WebView webView, NSDraggingInfo draggingInfo);

		[Export ("webView:dragSourceActionMaskForPoint:"), DelegateName ("DragSourceGetActionMask"), DefaultValue (0)]
		NSEventModifierMask UIDragSourceActionMask (WebView webView, CGPoint point);

Looks like you are correct. Unfortunately, we won't be able to fix it without breaking API compat, so it will have to wait until the next API break.

Note You need to log in before you can comment on or make changes to this bug.