Bug 45311 - Bug in constructor of AndroidHttpResponseMessage
Summary: Bug in constructor of AndroidHttpResponseMessage
Status: RESOLVED FIXED
Alias: None
Product: Android
Classification: Xamarin
Component: BCL Class Libraries (show other bugs)
Version: unspecified
Hardware: PC Windows
: --- normal
Target Milestone: ---
Assignee: Marek Habersack
URL:
Depends on:
Blocks:
 
Reported: 2016-10-12 11:36 UTC by David Petrík
Modified: 2016-10-13 12:39 UTC (History)
3 users (show)

See Also:
Tags:
Is this bug a regression?: ---
Last known good build:


Attachments

Description David Petrík 2016-10-12 11:36:31 UTC
We added your code around namespace Xamarin.Android.Net from GitHub directly into our project. Compiler found strange warning.

public AndroidHttpResponseMessage (URL javaUrl, HttpURLConnection httpConnection) {
			javaUrl = javaUrl;
			httpConnection = httpConnection;
		}


Warning	CS1717	Assignment made to same variable; did you mean to assign something else

This look like a bug. There must be "this" keyword, if you wan't to access class members :-)

David
Comment 1 Sam 2016-10-12 11:52:02 UTC
Would not cause an issue as the private field is never used.
Comment 2 David Petrík 2016-10-12 13:13:22 UTC
Private field is used in Dispose method. Correct disposing coul'd be important. It must consider the author of the code
Comment 3 Marek Habersack 2016-10-13 12:39:29 UTC
Fixed in https://github.com/xamarin/xamarin-android/pull/264 , thanks for spotting the issue!

Note You need to log in before you can comment on or make changes to this bug.