This is Xamarin's bug tracking system. For product support, please use the support links listed in your Xamarin Account.
Bug 44073 - VTCompressionSession does not handle null sample buffer
Summary: VTCompressionSession does not handle null sample buffer
Status: VERIFIED FIXED
Alias: None
Product: iOS
Classification: Xamarin
Component: General (show other bugs)
Version: XI 10.0 (iOS10)
Hardware: PC Windows
: Normal major
Target Milestone: 10.0.1 (C8SR0)
Assignee: Sebastien Pouliot
URL:
Depends on:
Blocks:
 
Reported: 2016-09-07 22:40 UTC by Cody Beyer (MSFT)
Modified: 2016-09-19 12:54 UTC (History)
4 users (show)

See Also:
Tags:
Is this bug a regression?: ---
Last known good build:


Attachments

Description Cody Beyer (MSFT) 2016-09-07 22:40:03 UTC
# Description

According to Apple documentation, VTCompressionSession.NewCompressionCallback() should accept a null value for the sample buffer

https://github.com/xamarin/xamarin-macios/blob/master/src/VideoToolbox/VTCompressionSession.cs#L112

According to the Apple headers, a null value is acceptable

>typedef void (*VTCompressionOutputCallback)(
>void * CM_NULLABLE outputCallbackRefCon,
>void * CM_NULLABLE sourceFrameRefCon,
>OSStatus status,
>VTEncodeInfoFlags infoFlags,
>CM_NULLABLE CMSampleBufferRef sampleBuffer );
Comment 1 Sebastien Pouliot 2016-09-13 15:57:53 UTC
PR (master) https://github.com/xamarin/xamarin-macios/pull/827
Comment 3 Sebastien Pouliot 2016-09-16 17:34:33 UTC
cherry-picked in xcode8 9b29b6c8ed93204ede218f829b752fca49284cbd

cherry-picked in cycle8-sr0-xi 484a4585129b89c02dd292302da835823d4297a6

Note You need to log in before you can comment on or make changes to this bug.