Bug 43681 - CBPeripheral eventa DiscoveredService and DiscoveredIncludedService incorrectly named
Summary: CBPeripheral eventa DiscoveredService and DiscoveredIncludedService incorrect...
Status: CONFIRMED
Alias: None
Product: iOS
Classification: Xamarin
Component: Xamarin.iOS.dll (show other bugs)
Version: XI 9.10 (C8)
Hardware: All All
: Low enhancement
Target Milestone: Future Cycle (TBD)
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2016-08-23 19:57 UTC by Tobias Boogh
Modified: 2016-08-24 12:28 UTC (History)
3 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report for Bug 43681 on Developer Community or GitHub if you have new information to add and do not yet see a matching new report.

If the latest results still closely match this report, you can use the original description:

  • Export the original title and description: Developer Community HTML or GitHub Markdown
  • Copy the title and description into the new report. Adjust them to be up-to-date if needed.
  • Add your new information.

In special cases on GitHub you might also want the comments: GitHub Markdown with public comments

Related Links:
Status:
CONFIRMED

Description Tobias Boogh 2016-08-23 19:57:04 UTC
CBPeripheral events:
public event EventHandler<NSErrorEventArgs> DiscoveredService
public event EventHandler<CBServiceEventArgs> DiscoveredIncludedService

are incorrectely named in singular, they should end with "Services"

Inscepting ICBPeripheralDelegate shows that the ProctolMemeber Name property is also incorrect

[ProtocolMember(IsProperty = false, IsRequired = false, IsStatic = false, Name = "DiscoveredService", ParameterByRef = new bool[] {false, false}, ParameterType = new Type[] {typeof (CBPeripheral), typeof (NSError)}, Selector = "peripheral:didDiscoverServices:")]
  [ProtocolMember(IsProperty = false, IsRequired = false, IsStatic = false, Name = "DiscoveredIncludedService", ParameterByRef = new bool[] {false, false, false}, ParameterType = new Type[] {typeof (CBPeripheral), typeof (CBService), typeof (NSError)}, Selector = "peripheral:didDiscoverIncludedServicesForService:error:")]
Comment 1 Sebastien Pouliot 2016-08-24 12:28:00 UTC
They are known issues but they are also API breaking changes that would affect existing binaries (e.g. 3rd part components being sold).

when (and if) we have to break API compatibility in the future we'll fix them, so you can keep reporting such issues. Thanks!