Bug 22308 - Make GetAttributeCompletions parse full XElement for all attributes
Summary: Make GetAttributeCompletions parse full XElement for all attributes
Status: RESOLVED FIXED
Alias: None
Product: Xamarin Studio
Classification: Desktop
Component: XML Editor (show other bugs)
Version: Trunk
Hardware: PC Mac OS
: Low enhancement
Target Milestone: master
Assignee: Bugzilla
URL:
: 22399 58761 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-08-22 13:54 UTC by Jérémie Laval
Modified: 2017-10-05 06:02 UTC (History)
3 users (show)

See Also:
Tags:
Is this bug a regression?: ---
Last known good build:


Attachments

Description Jérémie Laval 2014-08-22 13:54:41 UTC
The GetAttributeCompletions call has a very handy existingAtts parameter but due to the way the parser stop parsing at the caret, if you start adding new attributes in the middle of an existing attributes list like so:

<foo
   attr1="foo"
   at$
   attr2="bar" />

Then only the attr1="foo" attribute will find its way into the dictionary.
Comment 1 Mikayla Hutchinson [MSFT] 2014-08-22 15:36:59 UTC
The problem is the next attribute is a syntax error.

We'd need some kind of extra-tolerant mode, or maybe cache and inspect with the previous value parse unit.
Comment 2 David Karlaš 2017-09-08 14:15:33 UTC
*** Bug 22399 has been marked as a duplicate of this bug. ***
Comment 3 David Karlaš 2017-09-08 14:15:50 UTC
*** Bug 58761 has been marked as a duplicate of this bug. ***
Comment 4 xamarin-release-manager 2017-10-05 06:02:27 UTC
Fixed in version 7.4.0.241 (master)

Author: David Karlas??
Commit: 02905ab6a08d68d361cede575d66953c9fbf8342 (mono/monodevelop)

Note You need to log in before you can comment on or make changes to this bug.