Bug 2159 - regression in form closing event ordering
Summary: regression in form closing event ordering
Status: NEW
Alias: None
Product: Class Libraries
Classification: Mono
Component: Windows.Forms (show other bugs)
Version: 2.10.x
Hardware: PC Linux
: Lowest normal
Target Milestone: Community
Assignee: Bugzilla
Depends on:
Reported: 2011-11-22 13:38 UTC by Julian Taylor
Modified: 2017-09-01 11:56 UTC (History)
2 users (show)

See Also:
Tags: mono-community
Is this bug a regression?: ---
Last known good build:

program to reproduce (4.83 KB, application/x-gzip)
2011-11-22 13:38 UTC, Julian Taylor

Description Julian Taylor 2011-11-22 13:38:15 UTC
Created attachment 932 [details]
program to reproduce

since this commit: https://github.com/mono/mono/commit/cc39d7ebf1bfa8fafd6adc3a9fda354672579d1c
System.Windows.Forms.FormClosingEventHandler fires before button click events, even if it is the click even that closes the form.
This is not the case in windows .net, mono < 2.10 and mono 2.10.5 with that commit reverted.
It breaks e.g. keepass which relies on that ordering:

attached pretty minimal program reproduces the issue.
extract and build with xbuild. when executing and click on test and then on ok.
without that commit the expected ordering
$ mono bin/Debug/InputBoxSample.exe

with mono 2.10.5 including above commit the order is reversed:
$ mono bin/Debug/InputBoxSample.exe

I failed to compile trunk but the code seems unchanged there.
Comment 1 Tom 2012-01-28 08:00:17 UTC
I'm also having this issue, miss firing form events are making a mess of things, happy to test any patches. I'm on mono 2.10.8 release.

Note You need to log in before you can comment on or make changes to this bug.