Bug 19881 - ProductInfoHeaderValue fails to parse User-Agent string without version
Summary: ProductInfoHeaderValue fails to parse User-Agent string without version
Status: RESOLVED FIXED
Alias: None
Product: Class Libraries
Classification: Mono
Component: General (show other bugs)
Version: unspecified
Hardware: PC Windows
: --- normal
Target Milestone: Untriaged
Assignee: Marek Safar
URL:
Depends on:
Blocks:
 
Reported: 2014-05-19 00:25 UTC by David Karlaš
Modified: 2014-05-19 04:04 UTC (History)
1 user (show)

See Also:
Tags:
Is this bug a regression?: ---
Last known good build:


Attachments

Description David Karlaš 2014-05-19 00:25:27 UTC
This sample works fine on .Net but fails on mono:

var httpClient = new System.Net.Http.HttpClient();
httpClient.DefaultRequestHeaders.Add("User-Agent", "MonoDevelop (Unix 3.13.0; amd64; en-US; Octokit 0.3.4)");

Problem seems to be in https://github.com/mono/mono/blob/master/mcs/class/System.Net.Http/System.Net.Http.Headers/ProductInfoHeaderValue.cs#L157
Which eats up beginning of comment "(" so on next loop FormatError occurs because parsing commented string...
Comment 1 Marek Safar 2014-05-19 04:04:02 UTC
Fixed in master

Note You need to log in before you can comment on or make changes to this bug.