Bug 44978

Summary: HttpClientHandler.SendAsync should throw HttpRequestException for proxy auth failure
Product: [Mono] Class Libraries Reporter: Matt Ward <matt.ward>
Component: System.Net.HttpAssignee: Marek Safar <masafa>
Status: VERIFIED FIXED    
Severity: normal CC: mono-bugs+mono
Priority: ---    
Version: 4.8.0 (C9)   
Target Milestone: Untriaged   
Hardware: PC   
OS: Mac OS   
Tags: Is this bug a regression?: No
Last known good build:
Bug Depends on: 19594    
Bug Blocks:    

Description Matt Ward 2016-10-03 14:21:28 UTC
NuGet v3 fails to request proxy credentials in Mono because the HttpClient's HttpClientHandler throws a WebException instead of throwing a HttpRequestException with the WebException set as its InnerException.

On Windows a HttpRequestException is thrown with the error message: "An error occurred while sending the request." and the WebException is set as the HttpRequestException's InnerException.

Tests for this problem are available from the following GitHub repository:

https://github.com/mrward/MonoNuGet3ProxyTests/


NuGet v3.4.4 (unpatched for Mono) catches the HttpRequestException here:

https://github.com/NuGet/NuGet.Client/blob/3.4.4-rtm/src/NuGet.Core/NuGet.Protocol.Core.v3/HttpSource/HttpHandlerResourceV3Provider.cs#L115

NuGet v3.5 has been patched for Mono with the following commit which checks that the exception thrown is a WebException:

https://github.com/NuGet/NuGet.Client/commit/375d32dd21273fd8b05e560ee556e215eea2cedc
Comment 1 Marek Safar 2016-10-05 15:59:06 UTC
Fixed in master and 4.8 branch
Comment 2 Matt Ward 2016-10-06 10:17:33 UTC
This fix looks good to me.

There seems to be another different problem where credentials for the proxy are not accepted for https package sources. Package sources that use http are OK. Mono 4.4.1 is also OK. I will look into this other problem and open a new bug with a test repro.