Bug 44073

Summary: VTCompressionSession does not handle null sample buffer
Product: iOS Reporter: Cody Beyer (MSFT) <cody.beyer>
Component: GeneralAssignee: Sebastien Pouliot <sebastien>
Status: VERIFIED FIXED    
Severity: major CC: mono-bugs+monotouch, Rajneeshk, sebastien, vincent.dondain
Priority: Normal    
Version: XI 10.0 (iOS10)   
Target Milestone: 10.0.1 (C8SR0)   
Hardware: PC   
OS: Windows   
Tags: Is this bug a regression?: ---
Last known good build:

Description Cody Beyer (MSFT) 2016-09-07 22:40:03 UTC
# Description

According to Apple documentation, VTCompressionSession.NewCompressionCallback() should accept a null value for the sample buffer

https://github.com/xamarin/xamarin-macios/blob/master/src/VideoToolbox/VTCompressionSession.cs#L112

According to the Apple headers, a null value is acceptable

>typedef void (*VTCompressionOutputCallback)(
>void * CM_NULLABLE outputCallbackRefCon,
>void * CM_NULLABLE sourceFrameRefCon,
>OSStatus status,
>VTEncodeInfoFlags infoFlags,
>CM_NULLABLE CMSampleBufferRef sampleBuffer );
Comment 1 Sebastien Pouliot 2016-09-13 15:57:53 UTC
PR (master) https://github.com/xamarin/xamarin-macios/pull/827
Comment 3 Sebastien Pouliot 2016-09-16 17:34:33 UTC
cherry-picked in xcode8 9b29b6c8ed93204ede218f829b752fca49284cbd

cherry-picked in cycle8-sr0-xi 484a4585129b89c02dd292302da835823d4297a6