Bug 41775

Summary: Zip version needed to extract not correct in System.IO.Compression
Product: [Mono] Class Libraries Reporter: Bill Holmes <bill.holmes>
Component: GeneralAssignee: João Matos <joao.matos>
Status: VERIFIED FIXED    
Severity: normal CC: mono-bugs+mono, sachins
Priority: ---    
Version: 4.4.0 (C7)   
Target Milestone: Untriaged   
Hardware: PC   
OS: Mac OS   
Tags: Is this bug a regression?: ---
Last known good build:
Attachments: files to show the problem

Description Bill Holmes 2016-06-13 20:19:38 UTC
Created attachment 16305 [details]
files to show the problem

Found this with NuGet 3.4.4.  NuGet 3.4.4 packages that are created with Mono will cause errors when added to VS.

I have attached a simple case to reproduce the issue.  To run simply `sh run.sh`.

This script downloads Nuget 3.4.4 and runs a pack command.  Then I run zip with a fix argument and get a few warnings.  These warnings appear to be linked to what is causing the problem in VS.

Warning example...
zip warning: Local Version Needed To Extract does not match CD

I believe this is caused by this commit ot mono.
https://github.com/mono/mono/commit/77b034cbe78bfccfe4c1995152bd5562a1d69ef5

This commit attempted to change the 'version needed to extract' bytes.  For ZipWriter that appears to be correct.  However for ZipCentralDirectoryEntry I believe the 'version made by' bytes were changed.

The patch in the gist below fixes the issue for us.  The zip test referenced above works with the change as well as VS can not read the nupkg.

https://gist.github.com/bholmes/09c9a4e5a5c9a2f14831a7b2b7ce89aa