Bug 31451

Summary: mono_trace_set_printerr_handler calls g_set_print_handler instead of g_set_printerr_handler
Product: [Mono] Runtime Reporter: ikolev
Component: ToolsAssignee: Bugzilla <bugzilla>
Status: RESOLVED FIXED    
Severity: normal CC: mono-bugs+mono, mono-bugs+runtime, vargaz
Priority: ---    
Version: 4.0.0   
Target Milestone: ---   
Hardware: All   
OS: All   
Tags: Is this bug a regression?: ---
Last known good build:

Description ikolev 2015-06-29 03:37:05 UTC
On line 340 in the function mono_trace_set_printerr_handler in mono-4.0.2\mono\utils\mono-logger.c g_set_printerr_handler should be called instead of g_set_print_handler.
Comment 1 Zoltan Varga 2015-07-10 15:41:16 UTC
This is already fixed in mono master and the upcoming mono 4.2.
Comment 2 ikolev 2015-07-12 10:27:36 UTC
Doesn't seem that way to me. Looking at

https://github.com/mono/mono/blob/master/mono/utils/mono-logger.c

I still see the same code:

void
mono_trace_set_printerr_handler (MonoPrintCallback callback)
{
	g_assert (callback);
	printerr_callback = callback;
	g_set_print_handler (printerr_handler);
}

while g_set_print_handler should be g_set_printerr_handler.
The same is true about the mono-4.2.0-pre-branch and mono-4.2.0-pre2-branch.
Unless the latest changes have not yet been pushed to github.
Comment 3 Zoltan Varga 2015-07-12 12:35:49 UTC
Sorry about that, should be fixed now.