Bug 61058 - Add [Verify] for unsafe code
Summary: Add [Verify] for unsafe code
Status: NEW
Alias: None
Product: Objective Sharpie
Classification: Desktop
Component: General ()
Version: master
Hardware: PC Mac OS
: --- normal
Target Milestone: ---
Assignee: Aaron Bockover [MSFT]
Depends on:
Reported: 2017-12-08 20:53 UTC by Vincent Dondain [MSFT]
Modified: 2017-12-08 21:15 UTC (History)
0 users

Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.

Please create a new report for Bug 61058 on Developer Community or GitHub if you have new information to add and do not yet see a matching new report.

If the latest results still closely match this report, you can use the original description:

  • Export the original title and description: Developer Community HTML or GitHub Markdown
  • Copy the title and description into the new report. Adjust them to be up-to-date if needed.
  • Add your new information.

In special cases on GitHub you might also want the comments: GitHub Markdown with public comments

Related Links:

Description Vincent Dondain [MSFT] 2017-12-08 20:53:36 UTC
https://bugzilla.xamarin.com/show_bug.cgi?id=61056 is the result of a binding mistake where 'unsafe short* TriangleIndices { get; }' was ignore.

While the mistake "should" be easy to avoid because of 'unsafe short*' alone, maybe adding a nice '[Verify]' attribute would make this extra clear that it shouldn't be just bound to a 'short'.

You can take the generated sharpie output for ARKit's 'ARFaceGeometry' as a test case to fix this.
Comment 1 Vincent Dondain [MSFT] 2017-12-08 21:15:41 UTC
ARFaceGeometry's 'vertices' and 'textureCoordinates' also need fixing as they're 'vector_float3 *' and 'vector_float2 *'