Bug 59902 - Update PingTest.PingSuccess() for Android
Summary: Update PingTest.PingSuccess() for Android
Status: NEW
Alias: None
Product: Runtime
Classification: Mono
Component: General ()
Version: unspecified
Hardware: PC Mac OS
: --- normal
Target Milestone: ---
Assignee: Marek Habersack
Depends on:
Reported: 2017-10-02 16:17 UTC by Jonathan Pryor
Modified: 2017-10-02 16:24 UTC (History)
2 users (show)

Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.

Please create a new report for Bug 59902 on GitHub or Developer Community if you have new information to add and do not yet see a matching new report.

If the latest results still closely match this report, you can use the original description:

  • Export the original title and description: GitHub Markdown or Developer Community HTML
  • Copy the title and description into the new report. Adjust them to be up-to-date if needed.
  • Add your new information.

In special cases on GitHub you might also want the comments: GitHub Markdown with public comments

Related Links:

Description Jonathan Pryor 2017-10-02 16:17:13 UTC
Context: Bug #34883
Context: https://github.com/xamarin/xamarin-android/pull/872

The `MonoTests.System.Net.NetworkInformation.PingTest.PingSuccess()` test does not work on all Android devices, becomes some of them don't permit `ping`ing localhost. (Android, everyone!)

This was fixed with Bug #34883 by skipping execution of the test on certain "known bad" Android devices. However, this fix was never merged with mono proper.

Update the `MonoTests.System.Net.NetworkInformation.PingTest.PingSuccess()` test so that the device rejection logic is within mono, so that when xamarin-android uses the mono tests as-is, the correct behavior will continue to be used.
Comment 1 Jonathan Pryor 2017-10-02 16:24:08 UTC
A similar thing should be done for `Mono.Unix.Android.TestHelper.CanUseRealTimeSignals()`.