Bug 4454 - convert line endings message on save
Summary: convert line endings message on save
Alias: None
Product: Xamarin Studio
Classification: Desktop
Component: Project Model ()
Version: 2.9.x
Hardware: PC Mac OS
: --- critical
Target Milestone: ---
Assignee: Jeffrey Stedfast
Depends on:
Reported: 2012-04-16 00:01 UTC by James Clancey
Modified: 2012-04-16 16:14 UTC (History)
2 users (show)

Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.

Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:

Description James Clancey 2012-04-16 00:01:26 UTC
This feature has a major bug with it. It disables saving of the file. It should save the file first then warn.

Right now, it doesn't save but still compiles when you run build. This causes builds to run on the old version of the file outputting unexpected results.

There also needs to be a way to disable this. Due to source control, you may not want to ever change the line endings.
Comment 1 Mike Krüger 2012-04-16 00:32:35 UTC
There is a way to disable this btw.

btw. the build should not run when this message appears.

The bug is in ProjectOperations.cs - the DoBeforeCompileAction wraps the save all files call in a gui dispatch - this function then adds errors to the build result.

But the build result is evaluated before the gui dispatch runs. The DoBeforeCompileAction needs to be called before the compile action (as the name states). Atm it's called on the build thread - but should run on the gui thread.
Comment 2 Mike Krüger 2012-04-16 00:38:42 UTC
I think 
Revision: d35619b505a1c44676540d1fdee193b2506a17cc

[Ide] When saving all files during the build, do it on the main thread.

Fixes bug #2559.
broke it.

I would just call the do before compile action in the 'Build'/'Rebuild' functions - but I'm not 100% sure about the side effects here.
Comment 3 Jeffrey Stedfast 2012-04-16 16:14:01 UTC
fixed in git master