Bug 38619 - We do not retain actions in the .designer.cs in all cases
Summary: We do not retain actions in the .designer.cs in all cases
Status: RESOLVED FIXED
Alias: None
Product: Xamarin Studio
Classification: Desktop
Component: iOS Designer ()
Version: Trunk
Hardware: PC Mac OS
: --- normal
Target Milestone: (C7)
Assignee: Vinicius Jarina
URL:
Depends on:
Blocks:
 
Reported: 2016-02-10 11:49 UTC by Alan McGovern
Modified: 2016-02-11 15:04 UTC (History)
4 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Alan McGovern 2016-02-10 11:49:59 UTC
This test has started failing: https://github.com/xamarin/md-addins/commit/4a83530d0c4f4aecf55714138fd8927e3ab442a9

It looks like it should always have failed, so i don't really know why it started failing after a more-or-less unrelated commit. Either way, we are definitely *not* retaining the action in the .designer.cs and we should be.

The logic for both actions and outlets should be:
if (!actionOrOut.HasDesignerGeneratedAttribute ())
    CopyItFromTheOldFileIntoTheNewOne ();
Comment 1 Vinicius Jarina 2016-02-11 02:26:06 UTC
This should be fixed here: https://github.com/xamarin/md-addins/commit/195c843418de4e02faed7b861d0c9f1f08cce443