Bug 32540 - [APIBreak] NSWorkspace.LaunchApplication should use out NSError
Summary: [APIBreak] NSWorkspace.LaunchApplication should use out NSError
Alias: None
Product: Xamarin.Mac
Classification: Desktop
Component: Library (Xamarin.Mac.dll) ()
Version: 2.0.0
Hardware: PC Mac OS
: Normal normal
Target Milestone: master
Assignee: Bugzilla
Depends on:
Reported: 2015-07-28 14:37 UTC by iain
Modified: 2017-03-15 19:29 UTC (History)
5 users (show)

Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.

Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:

Description iain 2015-07-28 14:37:23 UTC
NSWorkspace.LaunchApplication (NSUrl, NSWorkspaceLaunchOptions, NSDictionary, NSError) should have an out parameter for NSError.
Comment 1 Sebastien Pouliot 2015-07-28 14:59:34 UTC
A quick look shows that SetDesktopImageUrl has the same issue (missing `out`). The whole type should be reviewed.

In fact all ", NSError " cases should be reviewed, they are likely incorrect unless it's a delegate (either a C# one or an ObjC one).
Comment 2 Greg Munn 2015-07-28 15:06:11 UTC
For what it's worth, with `launchApplication:options:error`, error is optional, whereas most of the other methods appear to have error required

"Returns, by-reference, the error if the application was unable to be launched. You may specify nil for this parameter if you do not want the error information."
Comment 4 Chris Hamons 2017-03-15 19:29:26 UTC
Looks fixed as @sebastien noted.