Bug 31307 - Synchronization code analysis rule - Usage of Interlocked
Summary: Synchronization code analysis rule - Usage of Interlocked
Status: NEW
Alias: None
Product: Xamarin Studio
Classification: Desktop
Component: C# Binding ()
Version: Trunk
Hardware: PC Windows
: Normal enhancement
Target Milestone: master
Assignee: Mike Krüger
URL:
Depends on:
Blocks:
 
Reported: 2015-06-23 02:32 UTC by Marius Ungureanu
Modified: 2015-06-25 05:00 UTC (History)
1 user (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report for Bug 31307 on Developer Community or GitHub if you have new information to add and do not yet see a matching new report.

If the latest results still closely match this report, you can use the original description:

  • Export the original title and description: Developer Community HTML or GitHub Markdown
  • Copy the title and description into the new report. Adjust them to be up-to-date if needed.
  • Add your new information.

In special cases on GitHub you might also want the comments: GitHub Markdown with public comments

Related Links:
Status:
NEW

Description Marius Ungureanu 2015-06-23 02:32:13 UTC
Basically this should transform simple constructs like:

if (myVar == null)
{
    lock (lockObject)
    {
        if (myVar == null) myVar = new VarType();
    }
}

lock (lockObject)
{
    if (myVar == null) myVar = new VarType();
}

Into:

Interlocked.CompareExchange(ref myVar, new VarType(), null);

lock (lockObject)
{
    if (myVar == null) myVar = new VarType();
}

Same with increment, decrement, addition, substraction on simple clauses.
Comment 1 Marius Ungureanu 2015-06-23 02:32:52 UTC
The `lock` part after Into shouldn't have been in the comment.