Bug 29413 - Add warnings for copy-paste smells
Summary: Add warnings for copy-paste smells
Status: NEW
Alias: None
Product: Xamarin Studio
Classification: Desktop
Component: C# Binding ()
Version: Trunk
Hardware: PC Windows
: Normal enhancement
Target Milestone: master
Assignee: Mike Krüger
Depends on:
Reported: 2015-04-27 02:34 UTC by Ciprian Khlud
Modified: 2015-04-29 07:03 UTC (History)
2 users (show)

Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.

Please create a new report for Bug 29413 on Developer Community or GitHub if you have new information to add and do not yet see a matching new report.

If the latest results still closely match this report, you can use the original description:

  • Export the original title and description: Developer Community HTML or GitHub Markdown
  • Copy the title and description into the new report. Adjust them to be up-to-date if needed.
  • Add your new information.

In special cases on GitHub you might also want the comments: GitHub Markdown with public comments

Related Links:

Description Ciprian Khlud 2015-04-27 02:34:52 UTC
There are many cases when users do copy-paste code.

Typical cases are sequences like:
a = b;
a = b;
Where a = a property accessor, the same array item, variable, and b = property, variable, function, constant.

in any logical condition: a&a, a|a,  a<a, a<=a, a>=a, etc. should be also marked as suspicious code where a is: property, variable, function, constant
It would be even better if a whould be for any logical expression.

Very important is this copy-paste bug as for me:

This can be firstly rewritten as only one block, but is very likely a copy-paste bug where the user copied the entire if block but forgot to change the condition inside the if.

Array assignment bugs:
a[index] = expr1;
a[index] = exprr2;