Bug 27301 - Bug in ToolbarTracker.UntrackTarget
Summary: Bug in ToolbarTracker.UntrackTarget
Alias: None
Product: Forms
Classification: Xamarin
Component: Forms ()
Version: 1.3.4
Hardware: PC Windows
: --- normal
Target Milestone: ---
Assignee: Bugzilla
Depends on:
Reported: 2015-02-23 08:40 UTC by Michael
Modified: 2015-03-05 06:48 UTC (History)
4 users (show)

Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.

Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:

Description Michael 2015-02-23 08:40:19 UTC
Saw this in 1.3.4.  Might be fixed in 1.3.5, but just wanted to point it out just in case:

private void UntrackTarget(Page page)
    if (page != null)
        ((ObservableCollection<ToolbarItem>) page.ToolbarItems).CollectionChanged += this.OnCollectionChanged;

I believe this should be a "-=" rather than "+=".  Looks like a copy/paste issue. :)  I apologize if I have this wrong.  It's something I noticed while checking out your internals and thought I would point it out.
Comment 1 Rui Marinho 2015-03-05 06:48:51 UTC
This should be fixed in 1.4.1-pre1