Bug 20818 - System.Net.Http.DelegatingHandler.Dispose() throws NullReferenceException if InnerHandler not assigned
Summary: System.Net.Http.DelegatingHandler.Dispose() throws NullReferenceException if ...
Alias: None
Product: Class Libraries
Classification: Mono
Component: General ()
Version: 3.4.0
Hardware: PC Windows
: --- normal
Target Milestone: Untriaged
Assignee: Marek Safar
Depends on:
Reported: 2014-06-23 11:42 UTC by Paul Turner
Modified: 2014-06-24 08:31 UTC (History)
2 users (show)

Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.

Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:

Description Paul Turner 2014-06-23 11:42:42 UTC
When disposed, the System.Net.Http.DelegatingHandler does not check whether the InnerHandler is set before calling Dispose, which raises NullReferenceException.

The following illustrates the issue:

	class TestHandler : System.Net.Http.DelegatingHandler

	class Program
		static void Main(string[] args)
			var handler = new TestHandler();

This behaviour deviates from the Microsoft implementation which throws no exception.

A simple fix would be to check whether the property is null before dereferencing and disposing.
Comment 1 Marek Safar 2014-06-24 08:31:54 UTC
Fixed in master