Bug 20612 - Imports added by NuGet should add Conditions to check the import exists
Summary: Imports added by NuGet should add Conditions to check the import exists
Status: RESOLVED FIXED
Alias: None
Product: Xamarin Studio
Classification: Desktop
Component: NuGet ()
Version: Trunk
Hardware: PC All
: Normal normal
Target Milestone: master
Assignee: Matt Ward
URL:
Depends on:
Blocks:
 
Reported: 2014-06-16 05:57 UTC by Matt Ward
Modified: 2014-06-17 08:21 UTC (History)
0 users

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Matt Ward 2014-06-16 05:57:10 UTC
When you install a NuGet package which uses a custom MSBuild .targets file, such as Xamarin.Forms, then an Import statement is added to the project. This import should have a Condition element which checks for the existence of the imported file.

Without the Condition added to the import when the project is opened with Visual Studio the project will fail to load if the packages are not restored.

Currently an import will be created similar to:

 <Import Project="..\packages\Xamarin.Forms.1.1.0.6201\build\portable-win+net45+wp80+MonoAndroid10+MonoTouch10\Xamarin.Forms.targets" />

When it should be:

 <Import Project="..\packages\Xamarin.Forms.1.1.0.6201\build\portable-win+net45+wp80+MonoAndroid10+MonoTouch10\Xamarin.Forms.targets" Condition="Exists('..\packages\Xamarin.Forms.1.1.0.6201\build\portable-win+net45+wp80+MonoAndroid10+MonoTouch10\Xamarin.Forms.targets')"/>
Comment 1 Matt Ward 2014-06-17 08:21:20 UTC
This should be fixed in commit:

https://github.com/mono/monodevelop/commit/34be5c15de5098d6ea9ceccb7364fae97f39f2e8