Bug 20291 - When no files exist in folder to select, Add file dialogue shows 'Include/Exclude All' & OK button in enabled state.
Summary: When no files exist in folder to select, Add file dialogue shows 'Include/Exc...
Status: VERIFIED FIXED
Alias: None
Product: Xamarin Studio
Classification: Desktop
Component: General ()
Version: 5.0
Hardware: All All
: Low minor
Target Milestone: master
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2014-06-03 04:30 UTC by Prashant manu
Modified: 2016-09-19 15:13 UTC (History)
5 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
VERIFIED FIXED

Description Prashant manu 2014-06-03 04:30:54 UTC
Steps to reproduce:
1. Open or create any application
2. At solution sidebar right click project and select option 'Add> Add Files from Folder'
3. Select any Empty folder having no files.
4. Click OK button

Actual Result:
When no files exist in folder to select, Add file dialogue shows 'Include/Exclude All' & OK button in enabled state.
Click OK button simply closes dialogue.

Expected Result:
When no files exist in folder to select, 'Include/Exclude All' & OK button should be in disabled state.

Screencast: http://www.screencast.com/t/Hf0RNzqeOr

Regression Status: NOT A REGRESSION same issue exist with stable XS 5.0(build 878).

Environment Info:
Xamarin Studio Version 5.1 (build 323)
Git revision: 3fa48ec1d1969b7b3f9de20326fb3687f612800f
Xamarin addins: b68a34ef2fc4c46b045dc38e26fb199bfe1b201d
Comment 1 Marcin Kolny 2015-02-23 16:56:37 UTC
I think, instead of empty window with no files, there should be message displayed, with "empty directory" info. I've already prepared a patch, but before submitting it, I'd like to know, what maintainers think about this message dialog.
Comment 2 Anubhav singh 2015-03-02 03:18:57 UTC
It would also be nice to add message dialog when no file is selected and 'ok' button is pressed because both the 'ok' and 'cancel' buttons simply does the same thing when no file is selected .. I have submitted a patch for that.. i guess this will help..
Comment 3 xamarin-release-manager 2015-03-20 13:12:21 UTC
Fixed in version 6.0.0.324 (new-project-model)
Comment 4 Lluis Sanchez 2015-03-20 13:32:34 UTC
Not yet fixed.
Comment 5 xamarin-release-manager 2015-03-24 13:22:09 UTC
Fixed in version 6.0.0.1166 (roslyn)
Comment 6 Naqeeb 2016-09-19 15:13:17 UTC
I have checked this issue on both Mac and Windows with latest master build and observed that it is working fine. When try to add any file in empty folder I am getting message "Directory is empty, no file have been added". Here is the screencast for the same: http://www.screencast.com/t/CAY6taZWyOP

Hence closing this issue.

Mac Environment info: https://gist.github.com/NaqeebAnsari/7f45bb14b2ddb8c900787c310e6e6c2b
Windows Environment info: https://gist.github.com/NaqeebAnsari/99a14620b75f55b4586716e9dbd9199c