Bug 14986 - Code Issue Request
Summary: Code Issue Request
Alias: None
Product: Xamarin Studio
Classification: Desktop
Component: C# Binding ()
Version: Trunk
Hardware: PC Windows
: Normal enhancement
Target Milestone: master
Assignee: Mike Krüger
Depends on:
Reported: 2013-09-25 11:45 UTC by Marius Ungureanu
Modified: 2015-05-18 03:40 UTC (History)
1 user (show)

Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.

Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:

Description Marius Ungureanu 2013-09-25 11:45:25 UTC
Let's say we have:

enum MyFlag
    Flag1 = 0x1,
    Flag2 = 0x2

and code like:

bool CheckFlag (MyFlag flags)
    // Can be written as: if (!flags.HasFlag (MyFlag.Flag2))
    if ((flags & MyFlag.Flag2) == 0)
        return false;

    // Can be written as: if (flags.HasFlag (MyFlag.Flag1))
    if ((flags & MyFlag.Flag1) == MyFlag1)
        return true;
    return false;
Comment 1 Mike Krüger 2013-09-25 11:53:55 UTC
I'm not really sure if I would like to do that.

I used the HasFlag approach when it got introduced - but it's a speed problem. I agree it's maybe more readable, but the HasFlag method is very slow in comparison.
Comment 2 Mike Krüger 2015-05-18 03:40:00 UTC
We've code refactorings for that now.